Skip to content

feat: show Raindex market data - #2848

Merged
findolor merged 1 commit into
mainfrom
arda/market-data-webapp
Aug 28, 2026
Merged

feat: show Raindex market data#2848
findolor merged 1 commit into
mainfrom
arda/market-data-webapp

Conversation

@findolor

@findolor findolor commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Chained PRs

Summary

  • Add a dedicated /markets Raindex market page that consumes only the public REST market service.
  • Show every active direct quote-token pair discovered from Raindex orders, with API-backed 24-hour statistics, token artwork when available, and on-demand executable depth.
  • Source market content from the public REST service while retaining the application shared layout and initialization behavior.

Key decisions

  • Present the route as a Raindex-level market view and link it immediately after Vaults in permanent navigation.
  • Refresh the cached overview each minute and quote only the selected market. TanStack Query cancellation prevents superseded requests from accumulating.
  • Render registry-provided token images when available and retain token initials as the missing-image fallback.
  • Treat 200 [] as healthy: counters render as zero and the page explains that no active Raindex orders currently provide a direct pair with the configured quote token.
  • Preserve the last successful overview or detail when a background refresh fails and surface a compact freshness status.
  • Keep scanning values concise while exposing unrounded API decimal strings in selected-market verification details.
  • Support search by symbol, token name/address, ticker ID, quote symbol, and chain ID without product category, ISIN, or market-enabled hardcoding.

Validation

  • npm run check: 0 errors and 0 warnings
  • npm run lint
  • Focused market/navigation/component tests: 8 passed
  • Full webapp suite: 32 files and 224 runnable tests passed; the existing network-dependent fullDeployment.test.ts could not fetch its remote registry and skipped 9 tests
  • npm run build
  • git diff --check
  • Manual local integration against the local API and index: 48 active markets rendered, including non-stock tokens; search, refresh, token artwork, empty executable depth, populated depth, exact values, and recent trades were verified.

Build output retains the repository existing sourcemap, large-chunk, and optional dependency warnings.

No issue is linked per the implementation scope.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d655c2c-6bb1-497e-955a-6227438f3596

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

findolor commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@findolor
findolor marked this pull request as ready for review August 25, 2026 15:19
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 5fa505e to e17c5c5 Compare August 25, 2026 15:22
@findolor
findolor force-pushed the arda/market-data-webapp branch 3 times, most recently from 62a433c to c4e5e8b Compare August 25, 2026 18:30
@findolor
findolor force-pushed the arda/market-data-rest-api branch from e17c5c5 to 4785a58 Compare August 25, 2026 18:30
@findolor
findolor force-pushed the arda/market-data-webapp branch from c4e5e8b to 7d6933f Compare August 25, 2026 18:31
@findolor
findolor force-pushed the arda/market-data-rest-api branch 2 times, most recently from 8c4fb69 to fe3aee3 Compare August 25, 2026 19:10
@findolor
findolor force-pushed the arda/market-data-webapp branch from 7d6933f to 06c4046 Compare August 25, 2026 19:10
@findolor
findolor force-pushed the arda/market-data-rest-api branch from fe3aee3 to 4a399b4 Compare August 26, 2026 06:38
@findolor
findolor force-pushed the arda/market-data-webapp branch from 06c4046 to af8394b Compare August 26, 2026 06:38
@findolor

findolor commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Updated Raindex market UI

Captured from the current Vercel preview: open the live markets page.

Desktop overview

Raindex market overview

Executable market detail

Raindex executable market orderbook and recent trades

Exact API values

Raindex exact market API values

Search across active-order tokens

The example below filters the Raindex-wide market list to WETH; discovery is not limited to stock tokens.

Raindex market search filtered to WETH

Mobile overview

Raindex mobile market overview

Mobile executable detail

Raindex mobile executable market detail

@findolor
findolor force-pushed the arda/market-data-rest-api branch from 4a399b4 to 740c1a6 Compare August 26, 2026 07:02
@findolor
findolor force-pushed the arda/market-data-webapp branch 2 times, most recently from 5b4f888 to 8c39bea Compare August 26, 2026 08:15
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 740c1a6 to 32a821b Compare August 26, 2026 08:15
@findolor
findolor force-pushed the arda/market-data-webapp branch from 8c39bea to 5d26caf Compare August 26, 2026 08:21
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 32a821b to 1961bbf Compare August 26, 2026 08:21
@findolor findolor self-assigned this Aug 26, 2026
@findolor
findolor requested a review from rouzwelt August 26, 2026 08:28
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 1961bbf to bbe3155 Compare August 26, 2026 08:40
@findolor
findolor force-pushed the arda/market-data-webapp branch from 5d26caf to 8564f45 Compare August 26, 2026 08:40
@findolor
findolor force-pushed the arda/market-data-rest-api branch from bbe3155 to 9d3bfc1 Compare August 26, 2026 08:43
@findolor
findolor force-pushed the arda/market-data-webapp branch from 8564f45 to 4520f05 Compare August 26, 2026 08:43
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 9d3bfc1 to 954ffb1 Compare August 26, 2026 08:45
@findolor findolor changed the title feat: show REST-backed market data feat: show Raindex market data Aug 26, 2026
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 8d442d7 to 74a54a7 Compare August 26, 2026 16:33
@findolor
findolor force-pushed the arda/market-data-webapp branch from 6308eba to 0d018d9 Compare August 26, 2026 16:33
@findolor
findolor requested a review from ueco-jb August 26, 2026 16:36
@findolor
findolor force-pushed the arda/market-data-webapp branch from 0d018d9 to 5c177cf Compare August 26, 2026 17:01
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 74a54a7 to 05a5495 Compare August 26, 2026 17:01
@findolor
findolor requested review from 0xgleb and agryaznov August 26, 2026 18:43
Comment thread packages/webapp/src/routes/markets/+page.svelte
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 05a5495 to f6dd9f7 Compare August 28, 2026 05:25
@findolor
findolor force-pushed the arda/market-data-webapp branch 2 times, most recently from 6f9f480 to 7601fc0 Compare August 28, 2026 05:38
@findolor
findolor force-pushed the arda/market-data-rest-api branch from f6dd9f7 to 15f111f Compare August 28, 2026 05:38
@findolor
findolor requested a review from ueco-jb August 28, 2026 06:23
Comment thread packages/webapp/src/lib/market-api/client.ts Outdated
Comment thread packages/webapp/src/routes/markets/+page.svelte Outdated
Comment thread packages/webapp/src/routes/markets/page.test.ts Outdated
Comment thread packages/webapp/src/lib/market-api/format.ts
@findolor
findolor force-pushed the arda/market-data-webapp branch from 7601fc0 to 0ef6ebc Compare August 28, 2026 12:32
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 15f111f to 7dae402 Compare August 28, 2026 12:32
@findolor
findolor requested a review from agryaznov August 28, 2026 12:56
Comment thread packages/webapp/src/routes/markets/+page.svelte Outdated

@agryaznov agryaznov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@findolor
findolor force-pushed the arda/market-data-webapp branch from 0ef6ebc to 35d1530 Compare August 28, 2026 15:24
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 7dae402 to a598997 Compare August 28, 2026 15:24
@findolor
findolor force-pushed the arda/market-data-webapp branch from 35d1530 to d99666f Compare August 28, 2026 15:36
@findolor
findolor force-pushed the arda/market-data-rest-api branch from a598997 to 286a028 Compare August 28, 2026 15:36
@findolor
findolor force-pushed the arda/market-data-rest-api branch from 286a028 to 28b8b46 Compare August 28, 2026 16:10
@findolor
findolor force-pushed the arda/market-data-webapp branch from d99666f to 58684f5 Compare August 28, 2026 16:10
@findolor
findolor changed the base branch from arda/market-data-rest-api to main August 28, 2026 16:41
@findolor
findolor merged commit 0e1ec41 into main Aug 28, 2026
19 of 21 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants